[webkit-changes] [WebKit/WebKit] 1cb92b: [popover] Fix togglePopover logic better

Rob Buis noreply at github.com
Thu Mar 9 08:30:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cb92be2e4ce7f84d31b5d7f8131bf6f8c251707
      https://github.com/WebKit/WebKit/commit/1cb92be2e4ce7f84d31b5d7f8131bf6f8c251707
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Fix togglePopover logic better
https://bugs.webkit.org/show_bug.cgi?id=253574

Reviewed by Manuel Rego Casasnovas.

PR #11233 did not take into account the case where popover data
was not set in the first place.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::togglePopover):

Canonical link: https://commits.webkit.org/261436@main




More information about the webkit-changes mailing list