[webkit-changes] [WebKit/WebKit] 361c5f: [WebAssembly] Fix tests and build on x86-64 Linux ...
Asumu Takikawa
noreply at github.com
Thu Mar 9 01:34:05 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 361c5fba483c9c157cf689d4e60acaccc45d74c5
https://github.com/WebKit/WebKit/commit/361c5fba483c9c157cf689d4e60acaccc45d74c5
Author: Asumu Takikawa <asumu at igalia.com>
Date: 2023-03-09 (Thu, 09 Mar 2023)
Changed paths:
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
M Source/cmake/WebKitFeatures.cmake
Log Message:
-----------
[WebAssembly] Fix tests and build on x86-64 Linux with BBQJIT
https://bugs.webkit.org/show_bug.cgi?id=253618
Reviewed by Yusuke Suzuki.
This patch first enables building of the BBQJIT on x86-64 Linux
platforms by adding a line in WebKitFeatures.cmake.
The rest of the patch fixes build issues with GCC.
- GCC doesn't support std::fabsf so use std::fabs instead.
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79700)
- GCC doesn't support explicit specialization in class scope so
this patch uses a `if constexpr` workaround.
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282)
- Add RELEASE_ASSERT_NOT_REACHED to suppress warnings.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::Location::fromArgumentLocation):
(JSC::Wasm::BBQJIT::loadOpForTypeKind):
(JSC::Wasm::BBQJIT::storeOpForTypeKind):
(JSC::Wasm::BBQJIT::addF32Copysign):
(JSC::Wasm::BBQJIT::fromJSCReg):
(JSC::Wasm::BBQJIT::fromJSCReg<RegisterID>): Deleted.
(JSC::Wasm::BBQJIT::fromJSCReg<FPRegisterID>): Deleted.
* Source/cmake/WebKitFeatures.cmake:
Canonical link: https://commits.webkit.org/261417@main
More information about the webkit-changes
mailing list