[webkit-changes] [WebKit/WebKit] 1fe8f8: [svg] text transformation not starting on initial ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fe8f8ec39961f73275ec569545709774886e2e5
      https://github.com/WebKit/WebKit/commit/1fe8f8ec39961f73275ec569545709774886e2e5
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    A LayoutTests/svg/text/text-transform-style-changed-by-script-expected.html
    A LayoutTests/svg/text/text-transform-style-changed-by-script.html
    M Source/WebCore/rendering/svg/RenderSVGBlock.h
    M Source/WebCore/rendering/svg/RenderSVGText.cpp
    M Source/WebCore/rendering/svg/RenderSVGText.h

  Log Message:
  -----------
  [svg] text transformation not starting on initial render
https://bugs.webkit.org/show_bug.cgi?id=253259

Reviewed by Nikolas Zimmermann.

RenderSVGText has a custom implementation for localTransform() and localToParentTransform() which
require setNeedsTransformUpdate() to be called when the transform needs an update. This would not
be called correctly when the transform was changed via script.

We now have an override for styleDidChange() which looks over transform-related RenderStyle methods
to determine whether style has changed.

* LayoutTests/svg/text/text-transform-style-changed-by-script-expected.html: Added.
* LayoutTests/svg/text/text-transform-style-changed-by-script.html: Added.
* Source/WebCore/rendering/svg/RenderSVGBlock.h:
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::styleDidChange):
* Source/WebCore/rendering/svg/RenderSVGText.h:

Canonical link: https://commits.webkit.org/261408@main