[webkit-changes] [WebKit/WebKit] db12f6: Fix crash in Document::topmostAutoPopover()

Chirag Shah noreply at github.com
Wed Mar 8 16:39:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db12f6fd8603d4a56bc07e7072aae0c934fa1f15
      https://github.com/WebKit/WebKit/commit/db12f6fd8603d4a56bc07e7072aae0c934fa1f15
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
    A LayoutTests/fast/html/popover-with-fullscreen-crash-expected.txt
    A LayoutTests/fast/html/popover-with-fullscreen-crash.html
    M Source/WebCore/dom/Document.cpp

  Log Message:
  -----------
  Fix crash in Document::topmostAutoPopover()
https://bugs.webkit.org/show_bug.cgi?id=253597
rdar://106423630

Reviewed by Tim Nguyen and Chris Dumez.

This change fixes a crash introduced recently by making sure candidate
is non-null before dereferencing it.

* LayoutTests/fast/html/popover-with-fullscreen-crash-expected.txt: Added.
* LayoutTests/fast/html/popover-with-fullscreen-crash.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::topmostAutoPopover const):

Canonical link: https://commits.webkit.org/261391@main




More information about the webkit-changes mailing list