[webkit-changes] [WebKit/WebKit] 28a6eb: [UI-side compositing] fast/canvas/webgl/lose-conte...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28a6eb594193c9b4fe94118ba2e3c0c0efa2bf64
      https://github.com/WebKit/WebKit/commit/28a6eb594193c9b4fe94118ba2e3c0c0efa2bf64
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async-expected.txt
    M LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async.html
    M LayoutTests/fast/canvas/webgl/lose-context-on-timeout-expected.txt
    M LayoutTests/fast/canvas/webgl/lose-context-on-timeout.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  -----------
  [UI-side compositing] fast/canvas/webgl/lose-context-on-timeout.html fails
https://bugs.webkit.org/show_bug.cgi?id=253496
rdar://106115219

Reviewed by Simon Fraser.

The simulated timeout mechanism does not at the moment apply immediately
because it posts work from GPUP RemoteGraphicsContextGL work queue to
main thread. Take this into account in lose-context-on-timeout.html
by ensuring that the call to be timed out is called potentially
multiple times.

Also fix other test problems related to lose-context-on-timeout.html
and the async variant:
- Use a method that is more likely not cached caller side
- Register the WebGL context lost handler before the context loss has
  chance of being invoked
- Use test metadata to always select GPUP WebGL as the testing variant.
  This way the testing skips can be removed from the TestExpectations
  and the test is run by default.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-async.html:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout-expected.txt:
* LayoutTests/fast/canvas/webgl/lose-context-on-timeout.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/261360@main