[webkit-changes] [WebKit/WebKit] 295f59: Cherry-pick 671758683829. rdar://problem/105998972

[Jer Noble]

  Branch: refs/heads/safari-7616.1.6-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 295f59ac6ec4c73094fd27030fb9f8c3f82eba6f
      https://github.com/WebKit/WebKit/commit/295f59ac6ec4c73094fd27030fb9f8c3f82eba6f
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M LayoutTests/platform/ios-wk2/TestExpectations
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm

  Log Message:
  -----------
  Cherry-pick 671758683829. rdar://problem/105998972

    REGRESSION(260774 at main):[ iOS ] 7X media/video layout-tests broke
    https://bugs.webkit.org/show_bug.cgi?id=253035
    rdar://105998972

    Reviewed by Eric Carlson.

    In 260774 at main, remote layer hosting was made possible by creating an instance of
    a WebAVPlayerLayer, WebAVPlayerLayerView, and WebAVPlayerController, the latter which
    has its properties set by PlaybackSessionManager/Proxy and subsequently pushes changes
    to those properties back down through PlaybackSessionManager/Proxy to the HTMLMediaElement
    backing it. When tracks are added to the HTMLMediaElement, that change is propogated up
    from the WebProcess to the UIProcess and pushed into the WebAVPlayerController. And in
    response the WebAVPlayerController notified the PlaybackSessionManagerProxy that its
    values had been changed. However, there was no validation inside the
    PlaybackSessionManagerProxy that the values in question were different than the ones
    it had just set, so each change from the HTMLMediaElement got reflected back.

    Add simple checks to a few setters in PlaybackSessionModelContext that did not
    already have them that validate that the new value represented a change before propogating
    that change back down to the HTMLMediaElement.

    * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
    (WebKit::PlaybackSessionModelContext::selectAudioMediaOption):
    (WebKit::PlaybackSessionModelContext::selectLegibleMediaOption):
    (WebKit::PlaybackSessionModelContext::setMuted):
    (WebKit::PlaybackSessionModelContext::setVolume):

    Canonical link: https://commits.webkit.org/261295@main

Canonical link: https://commits.webkit.org/261247.4@safari-7616.1.6-branch


  Commit: 434799baec4a4e19b957dd323901ccb15c7f48b8
      https://github.com/WebKit/WebKit/commit/434799baec4a4e19b957dd323901ccb15c7f48b8
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h

  Log Message:
  -----------
  Cherry-pick d5f4c908e83c. rdar://problem/106292744

    REGRESSION(261233 at main): Fix Simulator (and MacCatalyst) builds
    https://bugs.webkit.org/show_bug.cgi?id=253459
    <rdar://106292744>

    Reviewed by Ryosuke Niwa and Chris Dumez.

    The simulator and MacCatalyst do not yet support the Lockdown Mode
    Additions, leading to build failures.

    This patch adjusts the HAVE macro to avoid attempting to build with
    invalid settings.

    * Source/WTF/wtf/PlatformHave.h:

    Canonical link: https://commits.webkit.org/261296@main

Canonical link: https://commits.webkit.org/261247.5@safari-7616.1.6-branch


  Commit: dc778e0580df5b6e8c8aa6b0eabcf25798657058
      https://github.com/WebKit/WebKit/commit/dc778e0580df5b6e8c8aa6b0eabcf25798657058
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm

  Log Message:
  -----------
  Cherry-pick 34ef017d6046. rdar://problem/106271112

    CRASH: com.apple.WebKit.WebContent at TimerBase::~TimerBase
    https://bugs.webkit.org/show_bug.cgi?id=253456
    rdar://106271112

    Reviewed by Tim Horton.

    Enusre WKVideoLayerRemote (and by extension its _resolveBoundsTimer ivar) is destroyed on the main thread.

    * Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:
    (-[WKVideoLayerRemote dealloc]):

    Canonical link: https://commits.webkit.org/261298@main

Canonical link: https://commits.webkit.org/261247.6@safari-7616.1.6-branch


Compare: https://github.com/WebKit/WebKit/compare/3e2108e0170e...dc778e0580df