[webkit-changes] [WebKit/WebKit] 03e6b1: WASM SIMD VectorDotProduct should output lanes in ...

Justin Michaud noreply at github.com
Tue Mar 7 08:47:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03e6b1ff539c03ab185a9497c49f8ca76d5e773f
      https://github.com/WebKit/WebKit/commit/03e6b1ff539c03ab185a9497c49f8ca76d5e773f
  Author: Justin Michaud <justin_michaud at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    A JSTests/wasm/stress/simd-regress.js
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h

  Log Message:
  -----------
  WASM SIMD VectorDotProduct should output lanes in the correct order.
https://bugs.webkit.org/show_bug.cgi?id=253307
rdar://106264278

Reviewed by Yusuke Suzuki.

We fix a surprising and silly vectorDotProduct bug. It is surprising that
the spec tests didn't catch this.

* JSTests/wasm/stress/simd-regress.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.let.wat.module.func.main.export.string_appeared_here.result.i32.v128.const.i64x2.27866447905751188.27866447902605412.v128.const.i32x4.0x00080008.0x00080008.0x00080008.0x00080008.i32x4.dot_i16x8_s.i64x2.extract_lane.0.i64.const.6867652708672.i64.eq.async test):
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::vectorDotProduct):

Canonical link: https://commits.webkit.org/261326@main




More information about the webkit-changes mailing list