[webkit-changes] [WebKit/WebKit] b59118: [GTK] Crash in WebCore::Cairo::drawGlyphs if threa...

Carlos Garcia Campos noreply at github.com
Tue Mar 7 00:58:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b59118c2ad0b788abe2a4bd5f4163fad0d8095bd
      https://github.com/WebKit/WebKit/commit/b59118c2ad0b788abe2a4bd5f4163fad0d8095bd
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
    M Source/WebCore/platform/graphics/cairo/CairoUtilities.h

  Log Message:
  -----------
  [GTK] Crash in WebCore::Cairo::drawGlyphs if threaded rendering is enabled
https://bugs.webkit.org/show_bug.cgi?id=247628

Reviewed by Žan Doberšek.

We are now using a single rendering thread, but the main thread can
still use FreeType during the recording phase while laying out text. So,
we can try by using a global lock for FreeType.

* Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawGlyphs):
* Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::cairoFontLock):
* Source/WebCore/platform/graphics/cairo/CairoUtilities.h:
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):

Canonical link: https://commits.webkit.org/261318@main




More information about the webkit-changes mailing list