[webkit-changes] [WebKit/WebKit] e158a1: [WebGPU] Some command_encoder CTS tests do not pass
mwyrzykowski
noreply at github.com
Mon Mar 6 18:51:49 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e158a1d4ece234b2b2d612fd7a796a107e292b4a
https://github.com/WebKit/WebKit/commit/e158a1d4ece234b2b2d612fd7a796a107e292b4a
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2023-03-06 (Mon, 06 Mar 2023)
Changed paths:
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/Texture.mm
Log Message:
-----------
[WebGPU] Some command_encoder CTS tests do not pass
https://bugs.webkit.org/show_bug.cgi?id=253325
<radar://106199852>
Reviewed by Myles C. Maxfield.
This patch fixes two issues:
(1) copying zero-size is a no-op according to the specification.
(2) texelBlockWidth/height are not generally powers of two, so we
can't use WTF::roundUpToMultipleOf which requires the first argument
to be a power of two.
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::copyTextureToTexture):
No-op on zero size.
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::physicalMiplevelSpecificTextureExtent):
We could have written our own, but there is already an implementation
in bmalloc which is usable with casting from size_t -> uint32_t
Canonical link: https://commits.webkit.org/261303@main
More information about the webkit-changes
mailing list