[webkit-changes] [WebKit/WebKit] b35ab4: Revert 256469 at main as it violates the specification
Chris Dumez
noreply at github.com
Mon Mar 6 11:21:55 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b35ab41a5c7a3d289232d483f299c1cb92b6ef21
https://github.com/WebKit/WebKit/commit/b35ab41a5c7a3d289232d483f299c1cb92b6ef21
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-03-06 (Mon, 06 Mar 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/compat/idlharness.window-expected.txt
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/html/HTMLBodyElement+Compat.idl
M Source/WebCore/page/DOMWindow+Compat.idl
M Source/WebCore/page/DOMWindow.cpp
M Source/WebCore/page/DOMWindow.h
Log Message:
-----------
Revert 256469 at main as it violates the specification
https://bugs.webkit.org/show_bug.cgi?id=253435
rdar://106273441
Reviewed by Alex Christensen.
Revert 256469 at main. The specification [1] says that we should not expose this
API on non-mobile devices. This broke the Final Cut Pro download page as it
relies on this API being missing to detect we're on desktop.
Note that neither Firefox not Chrome expose the window orientation API on
Desktop.
[1] https://compat.spec.whatwg.org/#windoworientation-interface
* LayoutTests/imported/w3c/web-platform-tests/compat/idlharness.window-expected.txt:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/html/HTMLBodyElement+Compat.idl:
* Source/WebCore/page/DOMWindow+Compat.idl:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::orientation const):
* Source/WebCore/page/DOMWindow.h:
Canonical link: https://commits.webkit.org/261282@main
More information about the webkit-changes
mailing list