[webkit-changes] [WebKit/WebKit] f2c293: Move uses of PlatformGamepad* to being WeakPtrs or...

[Chirag Shah]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2c293349a71f5fd06594bf3a334e2e7a965ea74
      https://github.com/WebKit/WebKit/commit/f2c293349a71f5fd06594bf3a334e2e7a965ea74
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/gamepad/GamepadManager.cpp
    M Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp
    M Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp
    M Source/WebCore/platform/gamepad/EmptyGamepadProvider.h
    M Source/WebCore/platform/gamepad/GamepadProvider.cpp
    M Source/WebCore/platform/gamepad/GamepadProvider.h
    M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.h
    M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
    M Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp
    M Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.h
    M Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.h
    M Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm
    M Source/WebCore/platform/gamepad/mac/MultiGamepadProvider.h
    M Source/WebCore/platform/gamepad/mac/MultiGamepadProvider.mm
    M Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.cpp
    M Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.h
    M Source/WebCore/testing/MockGamepadProvider.cpp
    M Source/WebCore/testing/MockGamepadProvider.h
    M Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.cpp
    M Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.h

  Log Message:
  -----------
  Move uses of PlatformGamepad* to being WeakPtrs or containers that support WeakPtrs
https://bugs.webkit.org/show_bug.cgi?id=253331
rdar://106168221

Reviewed by Ryosuke Niwa and David Kilzer.

Now that GamepadProviderClient and PlatformGamepad inherit from
CanHaveWeakPtr, we should stop storing raw pointers where possible.

* Source/WebCore/Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadConnected):
(WebCore::GamepadManager::platformGamepadInputActivity):
* Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepads):
(WebCore::NavigatorGamepad::gamepadsBecameVisible):
* Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:
(WebCore::EmptyGamepadProvider::platformGamepads):
(): Deleted.
* Source/WebCore/platform/gamepad/EmptyGamepadProvider.h:
* Source/WebCore/platform/gamepad/GamepadProvider.cpp:
(WebCore::GamepadProvider::dispatchPlatformGamepadInputActivity):
* Source/WebCore/platform/gamepad/GamepadProvider.h:
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.h:
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
(WebCore::GameControllerGamepadProvider::controllerDidConnect):
(WebCore::GameControllerGamepadProvider::controllerDidDisconnect):
(WebCore::GameControllerGamepadProvider::startMonitoringGamepads):
(WebCore::GameControllerGamepadProvider::stopMonitoringGamepads):
(WebCore::GameControllerGamepadProvider::makeInvisibleGamepadsVisible):
(WebCore::GameControllerGamepadProvider::playEffect):
(WebCore::GameControllerGamepadProvider::stopEffects):
* Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp:
(WebCore::GamepadProviderLibWPE::startMonitoringGamepads):
(WebCore::GamepadProviderLibWPE::stopMonitoringGamepads):
(WebCore::GamepadProviderLibWPE::gamepadConnected):
(WebCore::GamepadProviderLibWPE::gamepadDisconnected):
* Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.h:
* Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.h:
* Source/WebCore/platform/gamepad/mac/HIDGamepadProvider.mm:
(WebCore::HIDGamepadProvider::startMonitoringGamepads):
(WebCore::HIDGamepadProvider::stopMonitoringGamepads):
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):
* Source/WebCore/platform/gamepad/mac/MultiGamepadProvider.h:
* Source/WebCore/platform/gamepad/mac/MultiGamepadProvider.mm:
(WebCore::MultiGamepadProvider::startMonitoringGamepads):
(WebCore::MultiGamepadProvider::stopMonitoringGamepads):
(WebCore::MultiGamepadProvider::platformGamepadConnected):
(WebCore::MultiGamepadProvider::platformGamepadDisconnected):
(WebCore::MultiGamepadProvider::platformGamepadInputActivity):
* Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.cpp:
(WebCore::ManetteGamepadProvider::startMonitoringGamepads):
(WebCore::ManetteGamepadProvider::stopMonitoringGamepads):
(WebCore::ManetteGamepadProvider::deviceConnected):
(WebCore::ManetteGamepadProvider::deviceDisconnected):
* Source/WebCore/platform/gamepad/manette/ManetteGamepadProvider.h:
* Source/WebCore/testing/MockGamepadProvider.cpp:
(WebCore::MockGamepadProvider::startMonitoringGamepads):
(WebCore::MockGamepadProvider::stopMonitoringGamepads):
(WebCore::MockGamepadProvider::connectMockGamepad):
(WebCore::MockGamepadProvider::disconnectMockGamepad):
* Source/WebCore/testing/MockGamepadProvider.h:
* Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::platformGamepads):
(): Deleted.
* Source/WebKit/WebProcess/Gamepad/WebGamepadProvider.h:

Canonical link: https://commits.webkit.org/261274@main