[webkit-changes] [WebKit/WebKit] 197b25: Add null checks needed to get site-isolated iframe...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 197b2532f73e0cdc0b14a23bbe28f7384a760eba
      https://github.com/WebKit/WebKit/commit/197b2532f73e0cdc0b14a23bbe28f7384a760eba
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/NavigationDisabler.h
    M Source/WebCore/page/FocusController.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Add null checks needed to get site-isolated iframe to load with RemoteFrame as a Page's main frame
https://bugs.webkit.org/show_bug.cgi?id=253391

Reviewed by Chris Dumez.

This is a bunch of seemingly randomly-located null checks that don't change behaviour
when site isolation is not turned on, and also don't do anything until a change I'm about
to make comes and makes the main frame a RemoteFrame in an iframe's process.  Then,
these changes allow the load to happen and get to the drawing code, which still needs a
little work.  All calls to dynamicDowncast<LocalFrame> indicate code that needs to be
audited later.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
* Source/WebCore/loader/NavigationDisabler.h:
(WebCore::NavigationDisabler::~NavigationDisabler):
(WebCore::NavigationDisabler::isNavigationAllowed):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedInternal):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResource):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::initWithCoreMainFrame):
(WebKit::WebFrame::isMainFrame const):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::setSize):
(WebKit::pageContainsAnyHorizontalScrollbars):

Canonical link: https://commits.webkit.org/261271@main