[webkit-changes] [WebKit/WebKit] 22e67b: [WGSL] Move TypeStore into ShaderModule

Tadeu Zagallo noreply at github.com
Mon Mar 6 01:14:44 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22e67bc4200400f8dd58bc73f59e9162448c210f
      https://github.com/WebKit/WebKit/commit/22e67bc4200400f8dd58bc73f59e9162448c210f
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/TypeStore.h
    M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  -----------
  [WGSL] Move TypeStore into ShaderModule
https://bugs.webkit.org/show_bug.cgi?id=253321
<rdar://problem/106197218>

Reviewed by Myles C. Maxfield.

In order to store types in the AST, since they'll outlive the TypeChecker,
we need to keep them alive for at least as long as the AST. In order to do
that, we move the TypeStore into WGSL::ShaderModule, which also holds the
AST.

* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::TemplateTypes::includes):
(WGSL::TemplateTypes::appendNameTo):
(WGSL::Parser<Lexer>::consumeTypes):
(WGSL::Types::includes): Deleted.
(WGSL::Types::appendNameTo): Deleted.
(WGSL::Types<TT>::includes): Deleted.
(WGSL::Types<TT>::appendNameTo): Deleted.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::TypeChecker):
* Source/WebGPU/WGSL/TypeStore.h:
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::types):

Canonical link: https://commits.webkit.org/261259@main




More information about the webkit-changes mailing list