[webkit-changes] [WebKit/WebKit] 6851ca: CSS @imports in HTML missing quote marks are mista...

Ahmad Saleem noreply at github.com
Sun Mar 5 21:50:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6851ca14bf62fb07839b4416333db9d5af417f38
      https://github.com/WebKit/WebKit/commit/6851ca14bf62fb07839b4416333db9d5af417f38
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-03-05 (Sun, 05 Mar 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative.html
    A LayoutTests/imported/w3c/web-platform-tests/loading/resources/dummy.css
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt
    M Source/WebCore/html/parser/CSSPreloadScanner.cpp

  Log Message:
  -----------
  CSS @imports in HTML missing quote marks are mistakenly hidden from the Preload Scanner

https://bugs.webkit.org/show_bug.cgi?id=191466

Reviewed by Chris Dumez.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Partial Merge - https://chromium.googlesource.com/chromium/src.git/+/30ecdaf63da0c5e1d81caf93c9836ec5564d9647

This fixes a couple of bugs with the CSSPreloadScanner that made it miss
rules in which the URL wasn't quoted or the rule didn't end with a
semicolon etc.

* Source/WebCore/html/parser/CSSPreloadScanner.cpp:
(parseCSSStringOrURL): Add comments and also add "if" clause for 'single' and
'double' clauses and do other clean-ups
* LayoutTests/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt: Add Test Case Expectation
* LayoutTests/imported/w3c/web-platform-tests/loading/resources/dummy.css: Add Test Resource
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/loading/preloader-css-import-no-quote.tentative-expected.txt: Add Platform Specific Expectation

Canonical link: https://commits.webkit.org/261254@main




More information about the webkit-changes mailing list