[webkit-changes] [WebKit/WebKit] bec59b: REGRESSION (STP 164): new failure in css/css-backg...

Darin Adler noreply at github.com
Sun Mar 5 17:04:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bec59bdd1e2679d403d84c3aefcd42618e3bc2cb
      https://github.com/WebKit/WebKit/commit/bec59bdd1e2679d403d84c3aefcd42618e3bc2cb
  Author: Darin Adler <darin at apple.com>
  Date:   2023-03-05 (Sun, 05 Mar 2023)

  Changed paths:
    M LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt
    M LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt
    M LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt
    M LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html
    M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt
    M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html
    M LayoutTests/fast/css/remove-shorthand-expected.txt
    M LayoutTests/fast/dom/background-shorthand-csstext-expected.txt
    M LayoutTests/fast/dom/background-shorthand-csstext.html
    M Source/WebCore/css/CSSProperties.json

  Log Message:
  -----------
  REGRESSION (STP 164): new failure in css/css-backgrounds/parsing/background-shorthand-serialization.html
https://bugs.webkit.org/show_bug.cgi?id=252925
rdar://problem/106208628

Reviewed by Tim Nguyen.

Revert the change from https://commits.webkit.org/260157@main that made background-color
serialize first. This is being discussed in https://github.com/w3c/csswg-drafts/issues/8496,
but while it's discussed, it seems good to change the behavior back since that matches
other browsers and some WPT test expectations.

* LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt:
Change expectations back to expect background-color to be serialized last, after the other
longhands that are part of the background shorthand
* LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt: Ditto.
* LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Ditto.
* LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Ditto.
* LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: Ditto.
* LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: Ditto.
* LayoutTests/fast/css/remove-shorthand-expected.txt: Ditto.
* LayoutTests/fast/dom/background-shorthand-csstext-expected.txt: Ditto.
* LayoutTests/fast/dom/background-shorthand-csstext.html: Ditto.

* Source/WebCore/css/CSSProperties.json: Move background-color to the end of the list of longhands
for the background shorthand.

Canonical link: https://commits.webkit.org/261250@main




More information about the webkit-changes mailing list