[webkit-changes] [WebKit/WebKit] 7aaf5f: [web-animations] update the accelerated effect sta...

Antoine Quint noreply at github.com
Sun Mar 5 00:32:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aaf5f7967bd256f5eace5dc479a30436191a5ee
      https://github.com/WebKit/WebKit/commit/7aaf5f7967bd256f5eace5dc479a30436191a5ee
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-03-05 (Sun, 05 Mar 2023)

  Changed paths:
    M Source/WebCore/animation/AnimationEffect.h
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/animation/CSSPropertyAnimation.h
    M Source/WebCore/animation/CSSTransition.cpp
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h

  Log Message:
  -----------
  [web-animations] update the accelerated effect stack as KeyframeEffect properties change
https://bugs.webkit.org/show_bug.cgi?id=253320

Reviewed by Dean Jackson.

We must make sure to update the accelerated effect stack when a number of KeyframeEffect
or WebAnimation properties change with threaded animation resolution enabled. We must also
disable any of the acceleration prevention with threaded animation resolution since these
situations will no longer arise.

* Source/WebCore/animation/AnimationEffect.h:
(WebCore::AnimationEffect::animationDidFinish):
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::getAcceleratedPropertyAtIndex):
* Source/WebCore/animation/CSSPropertyAnimation.h:
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::animationDidFinish):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::transformFunctionListPrefix const):
(WebCore::KeyframeEffect::animationTimelineDidChange):
(WebCore::KeyframeEffect::animationRelevancyDidChange):
(WebCore::KeyframeEffect::updateEffectStackMembership):
(WebCore::KeyframeEffect::didChangeTargetStyleable):
(WebCore::KeyframeEffect::preventsAcceleration const):
(WebCore::KeyframeEffect::updateAcceleratedAnimationIfNecessary):
(WebCore::KeyframeEffect::animationDidFinish):
(WebCore::KeyframeEffect::animationWasCanceled):
(WebCore::KeyframeEffect::willChangeRenderer):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
(WebCore::KeyframeEffect::setComposite):
(WebCore::KeyframeEffect::abilityToBeAcceleratedDidChange):
(WebCore::KeyframeEffect::CanBeAcceleratedMutationScope::CanBeAcceleratedMutationScope):
(WebCore::KeyframeEffect::CanBeAcceleratedMutationScope::~CanBeAcceleratedMutationScope):
(WebCore::acceleratedPropertyDidChange):
(WebCore::KeyframeEffect::lastStyleChangeEventStyleDidChange):
(WebCore::KeyframeEffect::StackMembershipMutationScope::StackMembershipMutationScope):
(WebCore::KeyframeEffect::StackMembershipMutationScope::~StackMembershipMutationScope):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::animationDidFinish):
(WebCore::WebAnimation::updateRelevance):
* Source/WebCore/animation/WebAnimation.h:
(WebCore::WebAnimation::animationDidFinish): Deleted.

Canonical link: https://commits.webkit.org/261242@main




More information about the webkit-changes mailing list