[webkit-changes] [WebKit/WebKit] 121ab6: image-decoders code fails to compile with -Wthread...
Myles C. Maxfield
noreply at github.com
Sat Mar 4 21:47:05 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 121ab62cae80a9f4b937c0cc4c3633ae52502dad
https://github.com/WebKit/WebKit/commit/121ab62cae80a9f4b937c0cc4c3633ae52502dad
Author: Myles C. Maxfield <mmaxfield at apple.com>
Date: 2023-03-04 (Sat, 04 Mar 2023)
Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp
M Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.h
A Source/WebCore/platform/image-decoders/jpegxl/JxlDecoderPtr.h
Log Message:
-----------
image-decoders code fails to compile with -Wthread-safety-analysis
https://bugs.webkit.org/show_bug.cgi?id=253397
rdar://106239523
Reviewed by Simon Fraser.
This patch mostly adds WTF_REQUIRES_LOCK() annotations to places that need it.
It also switches out use of C++ API to C API, for binary compatibility.
No test because there is no behavior change.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:
(WebCore::JPEGXLImageDecoder::imageOutCallback):
(WebCore::JPEGXLImageDecoder::prepareColorTransform):
* Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.h:
* Source/WebCore/platform/image-decoders/jpegxl/JxlDecoderRAII.h: Added.
(JxlDecoderPtr::JxlDecoderPtr):
(JxlDecoderPtr::operator=):
(JxlDecoderPtr::~JxlDecoderPtr):
(JxlDecoderPtr::reset):
(JxlDecoderPtr::operator bool const):
(JxlDecoderPtr::get const):
(JxlDecoderMake):
Canonical link: https://commits.webkit.org/261240@main
More information about the webkit-changes
mailing list