[webkit-changes] [WebKit/WebKit] c4ee07: Use smart pointers for PageConfiguration

Alex Christensen noreply at github.com
Sat Mar 4 09:35:55 PST 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4ee0780b3981bc7c1a6e4e0772a003e2e66bf61
      https://github.com/WebKit/WebKit/commit/c4ee0780b3981bc7c1a6e4e0772a003e2e66bf61
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-03-04 (Sat, 04 Mar 2023)

  Changed paths:
    M Source/WebCore/Modules/applepay/PaymentCoordinator.cpp
    M Source/WebCore/Modules/applepay/PaymentCoordinator.h
    M Source/WebCore/Modules/applepay/PaymentCoordinatorClient.cpp
    M Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h
    M Source/WebCore/inspector/InspectorController.cpp
    M Source/WebCore/inspector/InspectorController.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyClients.h
    M Source/WebCore/page/Chrome.cpp
    M Source/WebCore/page/Chrome.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/ContextMenuClient.h
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/ContextMenuController.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/PageConfiguration.cpp
    M Source/WebCore/page/PageConfiguration.h
    M Source/WebCore/svg/graphics/SVGImage.cpp
    M Source/WebCore/svg/graphics/SVGImage.h
    M Source/WebCore/svg/graphics/SVGImageClients.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/MockPaymentCoordinator.cpp
    M Source/WebCore/testing/MockPaymentCoordinator.h
    M Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp
    M Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.h
    M Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.h
    M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm
    M Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebPaymentCoordinatorClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Use smart pointers for PageConfiguration
https://bugs.webkit.org/show_bug.cgi?id=253348
rdar://106214366

Reviewed by Mark Lam.

Using std::unique_ptr is less error prone than new/delete.

* Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::PaymentCoordinator):
(WebCore::PaymentCoordinator::~PaymentCoordinator):
(WebCore::PaymentCoordinator::supportsVersion const):
(WebCore::PaymentCoordinator::canMakePayments):
(WebCore::PaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::PaymentCoordinator::openPaymentSetup):
(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::completeMerchantValidation):
(WebCore::PaymentCoordinator::completeShippingMethodSelection):
(WebCore::PaymentCoordinator::completeShippingContactSelection):
(WebCore::PaymentCoordinator::completePaymentMethodSelection):
(WebCore::PaymentCoordinator::completeCouponCodeChange):
(WebCore::PaymentCoordinator::completePaymentSession):
(WebCore::PaymentCoordinator::abortPaymentSession):
(WebCore::PaymentCoordinator::cancelPaymentSession):
(WebCore::PaymentCoordinator::validatedPaymentNetwork const):
(WebCore::PaymentCoordinator::getSetupFeatures):
(WebCore::PaymentCoordinator::beginApplePaySetup):
(WebCore::PaymentCoordinator::endApplePaySetup):
* Source/WebCore/Modules/applepay/PaymentCoordinator.h:
(WebCore::PaymentCoordinator::client):
* Source/WebCore/Modules/applepay/PaymentCoordinatorClient.cpp:
(WebCore::PaymentCoordinatorClient::supportsVersion const):
(WebCore::PaymentCoordinatorClient::supportsVersion): Deleted.
* Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:
* Source/WebCore/inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::createLazyAgents):
(WebCore::InspectorController::ensurePageAgent):
* Source/WebCore/inspector/InspectorController.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/Chrome.cpp:
(WebCore::Chrome::Chrome):
(WebCore::Chrome::~Chrome):
(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
(WebCore::Chrome::invalidateContentsForSlowScroll):
(WebCore::Chrome::scroll):
(WebCore::Chrome::screenToRootView const):
(WebCore::Chrome::rootViewToScreen const):
(WebCore::Chrome::accessibilityScreenToRootView const):
(WebCore::Chrome::rootViewToAccessibilityScreen const):
(WebCore::Chrome::platformPageClient const):
(WebCore::Chrome::contentsSizeChanged const):
(WebCore::Chrome::scrollContainingScrollViewsToRevealRect const):
(WebCore::Chrome::scrollMainFrameToRevealRect const):
(WebCore::Chrome::setWindowRect):
(WebCore::Chrome::windowRect const):
(WebCore::Chrome::pageRect const):
(WebCore::Chrome::focus):
(WebCore::Chrome::unfocus):
(WebCore::Chrome::canTakeFocus const):
(WebCore::Chrome::takeFocus):
(WebCore::Chrome::focusedElementChanged):
(WebCore::Chrome::focusedFrameChanged):
(WebCore::Chrome::createWindow):
(WebCore::Chrome::show):
(WebCore::Chrome::canRunModal const):
(WebCore::Chrome::runModal):
(WebCore::Chrome::setToolbarsVisible):
(WebCore::Chrome::toolbarsVisible const):
(WebCore::Chrome::setStatusbarVisible):
(WebCore::Chrome::statusbarVisible const):
(WebCore::Chrome::setScrollbarsVisible):
(WebCore::Chrome::scrollbarsVisible const):
(WebCore::Chrome::setMenubarVisible):
(WebCore::Chrome::menubarVisible const):
(WebCore::Chrome::setResizable):
(WebCore::Chrome::canRunBeforeUnloadConfirmPanel):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::closeWindow):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::setStatusbarText):
(WebCore::Chrome::mouseDidMoveOverElement):
(WebCore::Chrome::print):
(WebCore::Chrome::enableSuddenTermination):
(WebCore::Chrome::disableSuddenTermination):
(WebCore::Chrome::createColorChooser):
(WebCore::Chrome::createDataListSuggestionPicker):
(WebCore::Chrome::createDateTimeChooser):
(WebCore::Chrome::runOpenPanel):
(WebCore::Chrome::showShareSheet):
(WebCore::Chrome::showContactPicker):
(WebCore::Chrome::loadIconForFiles):
(WebCore::Chrome::screenSize const):
(WebCore::Chrome::availableScreenSize const):
(WebCore::Chrome::overrideScreenSize const):
(WebCore::Chrome::dispatchDisabledAdaptationsDidChange const):
(WebCore::Chrome::dispatchViewportPropertiesDidChange const):
(WebCore::Chrome::storeAppHighlight const):
(WebCore::Chrome::setCursor):
(WebCore::Chrome::setCursorHiddenUntilMouseMoves):
(WebCore::Chrome::createImageBuffer const):
(WebCore::Chrome::sinkIntoImageBuffer):
(WebCore::Chrome::createWorkerClient):
(WebCore::Chrome::createGraphicsContextGL const):
(WebCore::Chrome::createGPUForWebGPU const):
(WebCore::Chrome::selectItemWritingDirectionIsNatural):
(WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection):
(WebCore::Chrome::createPopupMenu const):
(WebCore::Chrome::createSearchPopupMenu const):
(WebCore::Chrome::requiresFullscreenForVideoPlayback):
(WebCore::Chrome::didReceiveDocType):
(WebCore::Chrome::setWindowRect const): Deleted.
(WebCore::Chrome::focus const): Deleted.
(WebCore::Chrome::unfocus const): Deleted.
(WebCore::Chrome::takeFocus const): Deleted.
(WebCore::Chrome::focusedElementChanged const): Deleted.
(WebCore::Chrome::focusedFrameChanged const): Deleted.
(WebCore::Chrome::createWindow const): Deleted.
(WebCore::Chrome::show const): Deleted.
(WebCore::Chrome::runModal const): Deleted.
(WebCore::Chrome::setToolbarsVisible const): Deleted.
(WebCore::Chrome::setStatusbarVisible const): Deleted.
(WebCore::Chrome::setScrollbarsVisible const): Deleted.
(WebCore::Chrome::setMenubarVisible const): Deleted.
(WebCore::Chrome::setResizable const): Deleted.
* Source/WebCore/page/Chrome.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebCore/page/ContextMenuClient.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
(WebCore::ContextMenuController::showContextMenuAt):
(WebCore::ContextMenuController::showImageControlsMenu):
* Source/WebCore/page/ContextMenuController.h:
(WebCore::ContextMenuController::client):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
* Source/WebCore/page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::~SVGImage):
(WebCore::SVGImage::dataChanged):
* Source/WebCore/svg/graphics/SVGImage.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::Internals):
* Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::validatedPaymentNetwork const):
(WebCore::MockPaymentCoordinator::validatedPaymentNetwork): Deleted.
* Source/WebCore/testing/MockPaymentCoordinator.h:
* Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::validatedPaymentNetwork const):
(WebKit::WebPaymentCoordinator::validatedPaymentNetwork): Deleted.
* Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect const):
(WebKit::WebChromeClient::pageRect const):
(WebKit::WebChromeClient::canTakeFocus const):
(WebKit::WebChromeClient::canRunModal const):
(WebKit::WebChromeClient::toolbarsVisible const):
(WebKit::WebChromeClient::statusbarVisible const):
(WebKit::WebChromeClient::scrollbarsVisible const):
(WebKit::WebChromeClient::menubarVisible const):
(WebKit::WebChromeClient::windowRect): Deleted.
(WebKit::WebChromeClient::pageRect): Deleted.
(WebKit::WebChromeClient::canTakeFocus): Deleted.
(WebKit::WebChromeClient::canRunModal): Deleted.
(WebKit::WebChromeClient::toolbarsVisible): Deleted.
(WebKit::WebChromeClient::statusbarVisible): Deleted.
(WebKit::WebChromeClient::scrollbarsVisible): Deleted.
(WebKit::WebChromeClient::menubarVisible): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::isSpeaking const):
(WebKit::WebContextMenuClient::isSpeaking): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::isSpeaking const):
(WebKit::WebContextMenuClient::isSpeaking): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::isSpeaking const):
(WebKit::WebPage::isSpeaking): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.h:
* Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::windowRect const):
(WebChromeClientIOS::windowRect): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::windowRect const):
(WebChromeClient::pageRect const):
(WebChromeClient::canTakeFocus const):
(WebChromeClient::canRunModal const):
(WebChromeClient::toolbarsVisible const):
(WebChromeClient::statusbarVisible const):
(WebChromeClient::scrollbarsVisible const):
(WebChromeClient::menubarVisible const):
(WebChromeClient::windowRect): Deleted.
(WebChromeClient::pageRect): Deleted.
(WebChromeClient::canTakeFocus): Deleted.
(WebChromeClient::canRunModal): Deleted.
(WebChromeClient::toolbarsVisible): Deleted.
(WebChromeClient::statusbarVisible): Deleted.
(WebChromeClient::scrollbarsVisible): Deleted.
(WebChromeClient::menubarVisible): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::isSpeaking const):
(WebContextMenuClient::isSpeaking): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::validatedPaymentNetwork const):
(WebPaymentCoordinatorClient::validatedPaymentNetwork): Deleted.
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Canonical link: https://commits.webkit.org/261225@main

More information about the webkit-changes mailing list