[webkit-changes] [WebKit/WebKit] aa1b9d: Blue boxes appear at ends of selection for live te...

Richard Robinson noreply at github.com
Fri Mar 3 20:16:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa1b9db26fd093f7d590af2d65ea4352289eac4f
      https://github.com/WebKit/WebKit/commit/aa1b9db26fd093f7d590af2d65ea4352289eac4f
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Blue boxes appear at ends of selection for live text for images with vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=253335
rdar://106106328

Reviewed by Wenson Hsieh.

`SelectionRenderingBehavior::UseIndividualQuads` doesn't currently work well for images
with a vertical writing mode, so this PR works around it by only using that behavior for
horizontal writing modes.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::adjustLineHeightOfSelectionGeometries):
(WebCore::RenderObject::collectSelectionGeometriesInternal):
(WebCore::RenderObject::collectSelectionGeometries):

Canonical link: https://commits.webkit.org/261209@main




More information about the webkit-changes mailing list