[webkit-changes] [WebKit/WebKit] 36c736: Attachment's save button click event is now always...

Gerald Squelart noreply at github.com
Fri Mar 3 19:59:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36c736481d50204339ae930b9922c6a03bb06aae
      https://github.com/WebKit/WebKit/commit/36c736481d50204339ae930b9922c6a03bb06aae
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/HTMLAttachmentElement.h

  Log Message:
  -----------
  Attachment's save button click event is now always named "save"
https://bugs.webkit.org/show_bug.cgi?id=253269
rdar://106108684

Reviewed by Tim Nguyen.

The HTML attribute "save" doesn't need a value anymore. If it's present with any value, the save button is shown, and clicking on it will dispatch a MouseEvent with type name "save".

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::saveAtom):
(WebCore::saveAttr):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::updateSaveButton):
(WebCore::HTMLAttachmentElement::parseAttribute):
* Source/WebCore/html/HTMLAttachmentElement.h:

Canonical link: https://commits.webkit.org/261206@main




More information about the webkit-changes mailing list