[webkit-changes] [WebKit/WebKit] ac186a: Block logd in WebContent

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac186a8cd8aeb6525562dd59a3d5ba86a6734aae
      https://github.com/WebKit/WebKit/commit/ac186a8cd8aeb6525562dd59a3d5ba86a6734aae
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/spi/cocoa/OSLogSPI.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
    M Source/WebKit/Scripts/process-entitlements.sh
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
    M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  -----------
  Block logd in WebContent
https://bugs.webkit.org/show_bug.cgi?id=253342
rdar://105416416

Reviewed by John Wilander.

Block logging service in the WebContent process sandbox unless the build is internal. This requires
some tweaks at startup of the WebContent process to avoid opening up a Mach connection to the service
before determining if logging should be enabled. Logs will be forwarded to the Networking process for
logging there if logging is disabled in the WebContent process. This feature is off by default, and
will only be enabled by default after further discussion and review from a larger group of stake-
holders. Initial performance measurements indicate that this feature is neutral and possibly even a
progression on page load benchmarks.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/spi/cocoa/OSLogSPI.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::initializeCFPrefs):
(WebKit::blockLogdInSandbox):
(WebKit::initializeLogd):
(WebKit::XPCServiceEventHandler):
(WebKit::XPCServiceMain):
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::registerLogHook):
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::initializeLogd): Deleted.
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/261201@main