[webkit-changes] [WebKit/WebKit] 41910e: [ews] Send only important steps info to ews-app

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41910e61bbb5a7db89c0689a6e2819853b66fb88
      https://github.com/WebKit/WebKit/commit/41910e61bbb5a7db89c0689a6e2819853b66fb88
  Author: Aakash Jain <aakash_jain at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Tools/CISupport/ews-app/ews/common/github.py
    M Tools/CISupport/ews-app/ews/views/statusbubble.py
    M Tools/CISupport/ews-build/events.py

  Log Message:
  -----------
  [ews] Send only important steps info to ews-app
https://bugs.webkit.org/show_bug.cgi?id=253341

Reviewed by Ryan Haddad.

EWS (buildbot) should send only important steps info to ews-app. Currently it's
sending information of every step start/stop to ews django app. Then django app
filters out which steps info to use. Instead EWS should just filter out the step
and send only required info to ews-app.

Also, step information is only used to display status-bubble hover-over summary.
Step information in hover-over messages are less useful in GitHub as compared to bugzilla,
since there are limitations in Github on how we can display hover-over messages.
We should only display useful information in hover-over messages.

Therefore we should send step information for only the important steps (which we
really want to show in hover-over messages). This would save thousands of network
requests every hour from buildbot-server, and would help with load on buildbot server.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS._should_display_step): Deleted.
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
(StatusBubble._steps_messages_from_multiple_builds):
(StatusBubble._should_display_step): Deleted.
* Tools/CISupport/ews-build/events.py:
(Events): Added list of steps which should be reported to ews django app.
(Events.stepStarted):
(Events.stepFinished):

Canonical link: https://commits.webkit.org/261168@main