[webkit-changes] [WebKit/WebKit] 5c2607: Add assertions in CacheStorageCache to help debug ...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c2607837be66195328f71725114deca9306f2dc
      https://github.com/WebKit/WebKit/commit/5c2607837be66195328f71725114deca9306f2dc
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
    M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h

  Log Message:
  -----------
  Add assertions in CacheStorageCache to help debug threading issues
https://bugs.webkit.org/show_bug.cgi?id=253223
rdar://106124999

Reviewed by Chris Dumez.

rdar://105122133 indicates CacheStorageCache may have threading issues (e.g. record url may become AtomString at some
point), so adding some assertion to help debug that.

This patch also make an isolated copy for record url before passing it to CacheStorageCache.

* Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp:
(WebKit::computeKeyURL):
(WebKit::CacheStorageCache::CacheStorageCache):
(WebKit::CacheStorageCache::getSize):
(WebKit::CacheStorageCache::open):
(WebKit::CacheStorageCache::retrieveRecords):
(WebKit::CacheStorageCache::removeRecords):
(WebKit::CacheStorageCache::findExistingRecord):
(WebKit::CacheStorageCache::putRecords):
(WebKit::CacheStorageCache::putRecordsAfterQuotaCheck):
(WebKit::CacheStorageCache::putRecordsInStore):
(WebKit::CacheStorageCache::removeAllRecords):
(WebKit::CacheStorageCache::close):
* Source/WebKit/NetworkProcess/storage/CacheStorageCache.h:
(WebKit::CacheStorageCache::assertIsOnCorrectQueue):

Canonical link: https://commits.webkit.org/261147@main