[webkit-changes] [WebKit/WebKit] a28ad5: AX: Remove unnecessary caching of title() and acce...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a28ad53763a51538acaf0e2e28f8eaa7d239ef52
      https://github.com/WebKit/WebKit/commit/a28ad53763a51538acaf0e2e28f8eaa7d239ef52
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityImageMapLink.cpp
    M Source/WebCore/accessibility/AccessibilityImageMapLink.h
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilitySVGElement.cpp
    M Source/WebCore/accessibility/AccessibilitySVGElement.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Remove unnecessary caching of title() and accessibilityDescription() in AXIsolatedObject.
https://bugs.webkit.org/show_bug.cgi?id=253210
<rdar://problem/106115890>

Reviewed by Chris Fleizach.

These two properties were being cached in the AXIsolatedObject initialization, but they were only used as separate properties in the search algorithm Accessibility::isAccessibilityTextSearchMatch(...). Instead, we now cache textContent(), which closer matches the text that is conveyed to the AX client to represent the object. This avoids possible duplications of cached text, and may make text searches more consistent with the conveyed content. In addition, textContent() will be used in a follow up patch as the text buffer on which to base TextMarkers. Some code cleanup.

* Source/WebCore/accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::accessibilityText const):
(WebCore::AccessibilityImageMapLink::description const):
(WebCore::AccessibilityImageMapLink::nameForMSAA const):
(WebCore::AccessibilityImageMapLink::accessibilityDescription const): Renamed description()
* Source/WebCore/accessibility/AccessibilityImageMapLink.h:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::description const):
(WebCore::AccessibilityNodeObject::helpText const):
(WebCore::AccessibilityNodeObject::accessibilityDescription const): Renamed description.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textContent const):
(WebCore::Accessibility::isAccessibilityTextSearchMatch):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::title const):
(WebCore::AccessibilityObject::description const):
(WebCore::AccessibilityObject::helpText const):
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText const):
(WebCore::AccessibilityRenderObject::descriptionForMSAA const):
* Source/WebCore/accessibility/AccessibilitySVGElement.cpp:
(WebCore::AccessibilitySVGElement::accessibilityText const):
(WebCore::AccessibilitySVGElement::description const):
(WebCore::AccessibilitySVGElement::helpText const):
(WebCore::AccessibilitySVGElement::accessibilityDescription const): Renamed description.
* Source/WebCore/accessibility/AccessibilitySVGElement.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/261139@main