[webkit-changes] [WebKit/WebKit] d4f4ae: AX: input[type=date] individual fields are announc...

[EWS]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4f4aedd06563422f36fff424b3592646262e0f3
      https://github.com/WebKit/WebKit/commit/d4f4aedd06563422f36fff424b3592646262e0f3
  Author: Chris Gilardi <chris.gilardi at vidaloop.com>
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
    A LayoutTests/accessibility/date-input-aria-label-and-value-expected.txt
    A LayoutTests/accessibility/date-input-aria-label-and-value.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/html/shadow/DateTimeFieldElements.cpp
    M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp
    M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h

  Log Message:
  -----------
  AX: input[type=date] individual fields are announced as "group"
https://bugs.webkit.org/show_bug.cgi?id=251544
rdar://problem/104928713

Reviewed by Aditya Keerthi.

This fixes the bug by adding labels representing the "day", "month", and "year" inputs so that a screen reader has something to read,
instead of just "group" - it also switches the "role" attribute of the same divs to "spinbutton" to more accurately
reflect how they are used.

* LayoutTests/accessibility/date-input-aria-label-and-value-expected.txt: Added.
* LayoutTests/accessibility/date-input-aria-label-and-value.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):
* Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::setARIAValueAttributesWithInteger):
* Source/WebCore/html/shadow/DateTimeNumericFieldElement.h:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::AXDateFieldMonthText):
(WebCore::AXDateFieldDayText):
(WebCore::AXDateFieldYearText):
* Source/WebCore/platform/LocalizedStrings.h:

Canonical link: https://commits.webkit.org/261123@main