[webkit-changes] [WebKit/WebKit] 85232d: REGRESSION(260575 at main): [iPad] Crash when navigat...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85232d38f6f47e56b100d840dea69d708888a013
      https://github.com/WebKit/WebKit/commit/85232d38f6f47e56b100d840dea69d708888a013
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

  Log Message:
  -----------
  REGRESSION(260575 at main): [iPad] Crash when navigating to next YouTube video in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=253246
rdar://106112303

Reviewed by Tim Horton.

Remove the MESSAGE_CHECK protecting against videoLayerID being zero in setupFullscreenWithID(). Prior to the
no-double-hosting change, it was impossible to enter this function without a remote layer host having been
created in the WebContent process. After the no-double-hosting change, the remote layer host is created in
the GPU process, and may not have been created by the time setupFullscreenWithID() is called. Once the layer
_is_ created, the videoLayerID is sent to the UI process separately, and the created hosting layer is updated.

* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):

Canonical link: https://commits.webkit.org/261104@main