[webkit-changes] [WebKit/WebKit] 0cc968: Build fixes for !ENABLE(SERVICE_WORKER) after 2609...

Stephan Szabo noreply at github.com
Thu Mar 2 13:31:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0cc96819dbaf270ff4d6ac9db974159d46bc6c06
      https://github.com/WebKit/WebKit/commit/0cc96819dbaf270ff4d6ac9db974159d46bc6c06
  Author: Stephan Szabo <stephan.szabo at sony.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h
    M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp
    M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in

  Log Message:
  -----------
  Build fixes for !ENABLE(SERVICE_WORKER) after 260990 at main
https://bugs.webkit.org/show_bug.cgi?id=253187

Reviewed by Alex Christensen.

Add ENABLE(SERVICE_WORKER) guards to code in OriginStorageManager
that is using StorageType::BackgroundFetchStorage.

We saw errors where the generated serializers appeared to be effectively
missing the trailing semi-colon on the allValidBitsValue calculation
in isValidOptionSet due to the last item being in a preprocessor if.
Add a check for the case where the last item is in such an if and add an
else that provides the semi-colon.

* Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::toStorageIdentifier const):
(WebKit::OriginStorageManager::StorageBucket::resolvedPath):
* Source/WebKit/Scripts/generate-serializers.py:
(generate_impl):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
* Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in:

Canonical link: https://commits.webkit.org/261094@main




More information about the webkit-changes mailing list