[webkit-changes] [WebKit/WebKit] deb637: [GPU Process][FormControls] Remove the flipping wo...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: deb6370ae7025c39a7f2cc8263a04330872bd2e6
      https://github.com/WebKit/WebKit/commit/deb6370ae7025c39a7f2cc8263a04330872bd2e6
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/cocoa/LocalCurrentGraphicsContext.h
    M Source/WebCore/platform/graphics/mac/controls/ControlMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
    M Source/WebCore/platform/ios/LocalCurrentGraphicsContextIOS.mm
    M Source/WebCore/platform/mac/LocalCurrentGraphicsContextMac.mm

  Log Message:
  -----------
  [GPU Process][FormControls] Remove the flipping workaround for drawing a viewless NSCell
https://bugs.webkit.org/show_bug.cgi?id=252427
rdar://105563614

Reviewed by Aditya Keerthi.

This patch will remove part of the workaround which was added in 260210 at main.
But we still need to un-flip the flipped coordinates system before asking AppKit
to draw the NSCells. The only difference this patch makes is we will un-flip the
context unconditionally for all NSCell types.

* Source/WebCore/platform/cocoa/LocalCurrentGraphicsContext.h:
* Source/WebCore/platform/graphics/mac/controls/ControlMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::drawSliderCell):
(WebCore::drawViewlessCell):
(WebCore::drawCellInView):
(WebCore::ControlMac::drawCellInternal):
(WebCore::ControlMac::drawCellFocusRingInternal):
(WebCore::ControlMac::drawCellFocusRing):
(WebCore::ControlMac::drawCellOrFocusRing):
(WebCore::shouldFlipContext): Deleted.
* Source/WebCore/platform/ios/LocalCurrentGraphicsContextIOS.mm:
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
* Source/WebCore/platform/mac/LocalCurrentGraphicsContextMac.mm:
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):

Canonical link: https://commits.webkit.org/261085@main