[webkit-changes] [WebKit/WebKit] 2efdbd: Styled text and search fields override their backg...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2efdbd54bbada1a21df36fd13f6031a35712300b
      https://github.com/WebKit/WebKit/commit/2efdbd54bbada1a21df36fd13f6031a35712300b
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/ios/fast/css/text-input-with-webkit-border-radius-expected.txt
    M Source/WebCore/rendering/RenderThemeIOS.mm

  Log Message:
  -----------
  Styled text and search fields override their backgrounds with alternate form control design enabled
https://bugs.webkit.org/show_bug.cgi?id=253093
rdar://105803404

Reviewed by Aditya Keerthi.

Web content that overrides certain CSS properties on input elements is specified
to disable the UA appearance in https://drafts.csswg.org/css-ui/#appearance-disabling-properties

Our existing code only covers a subset of these properties, and only on a subset
of text-field-like input fields.

* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::isControlStyled const):
FillLayer does not include color, so overriding background color did not drop you out of the UA appearance.
Similarly, adjustments to borders are supposed to drop you out of UA appearance.
Fix both things by adopting borderAndBackgroundEqual, which tests the FillLayers, background color, and borders.

Add search fields to the set of text-field-like fields that get this behavior, as well.

Canonical link: https://commits.webkit.org/261073@main