[webkit-changes] [WebKit/WebKit] fbd617: [GStreamer][Webaudio] Exclude Broadcom native audi...

Xabier Rodríguez noreply at github.com
Thu Mar 2 07:27:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fbd617fdbc5777b535bec55dcd4ac38eb769bff6
      https://github.com/WebKit/WebKit/commit/fbd617fdbc5777b535bec55dcd4ac38eb769bff6
  Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp

  Log Message:
  -----------
  [GStreamer][Webaudio] Exclude Broadcom native audio decoding path from webaudio decoder
https://bugs.webkit.org/show_bug.cgi?id=253150

Reviewed by Philippe Normand.

Extend skipping of "brcmaudfilter" element on BROADCOM platform also
(beside BCM_NEXUS). This way we drop Broadcom native audio decoding
path that doesn't produce raw audio output anyway.

This fixes webaudio AudioContext.decodeAudioData() pipeline creation
error for audio formats with sw decoder available. Now decodebin
will automatically pick up sw decoder if available instead of brcm.

Patch by Andrzej Surdej <Andrzej_Surdej at comcast.com>.

* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

Canonical link: https://commits.webkit.org/261066@main




More information about the webkit-changes mailing list