[webkit-changes] [WebKit/WebKit] 8cfac2: Send policy decision responses to correct process ...
Alex Christensen
noreply at github.com
Thu Mar 2 00:17:39 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8cfac266c6454819b4bcbca59c8cd4c6ac181f1a
https://github.com/WebKit/WebKit/commit/8cfac266c6454819b4bcbca59c8cd4c6ac181f1a
Author: Alex Christensen <achristensen at apple.com>
Date: 2023-03-02 (Thu, 02 Mar 2023)
Changed paths:
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/page/AbstractFrame.h
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/Frame.h
M Source/WebCore/page/RemoteFrame.cpp
M Source/WebCore/page/RemoteFrame.h
M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
M Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm
Log Message:
-----------
Send policy decision responses to correct process when navigating site isolated iframes
https://bugs.webkit.org/show_bug.cgi?id=253197
rdar://106108279
Reviewed by Chris Dumez.
Instead of using the WebPageProxy's process, use the WebFrameProxy's process for sending the reply.
When site isolation is not enabled, these are always the same.
Grandchild iframes were not starting to load without this change when site isolation is enabled.
Since the site isolation tests are getting further than they did before, implement a little
more of the logic to make the load event of the parent frame happen at the right time.
* Source/WebKit/UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::process):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::decidePolicyForResponse):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/261050@main
More information about the webkit-changes
mailing list