[webkit-changes] [WebKit/WebKit] a2b0b7: [IFC][Partial layout] Partial inline item building...

Alan Baradlay noreply at github.com
Wed Mar 1 22:13:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2b0b78fe1f01e70d96bdc70c5ddf6e815ab2d99
      https://github.com/WebKit/WebKit/commit/a2b0b78fe1f01e70d96bdc70c5ddf6e815ab2d99
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/partial-layout-with-damage-at-inline-box-start-crash-expected.txt
    A LayoutTests/fast/inline/partial-layout-with-damage-at-inline-box-start-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  [IFC][Partial layout] Partial inline item building misses inline-box-start
https://bugs.webkit.org/show_bug.cgi?id=253134
<rdar://106028030>

Reviewed by Antti Koivisto.

Partial inline item builder (where we turn the tree structure into a flat one) is supposed to initialize the layout queue all
the way up to the damaged box, so that the actual "building" loop can start building the inline items right at the damaged content.

Let's move to a simple, recursive approach as we don't need to process individual layout boxes here.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::collectInlineItems):

Canonical link: https://commits.webkit.org/261039@main




More information about the webkit-changes mailing list