[webkit-changes] [WebKit/WebKit] 3562bf: [WebGPU] Several command_buffer CTS tests are failing

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3562bf391e2bd4914be4280a1a042788858d7582
      https://github.com/WebKit/WebKit/commit/3562bf391e2bd4914be4280a1a042788858d7582
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/basic-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/clearBuffer-expected.txt
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyBufferToBuffer-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.cpp
    M Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] Several command_buffer CTS tests are failing
https://bugs.webkit.org/show_bug.cgi?id=253190
<radar://106103778>

Reviewed by Myles C. Maxfield.

Enable first 3 command buffer tests and update test expectations.

* LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/basic-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/clearBuffer-expected.txt:
* LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyBufferToBuffer-expected.txt:
* LayoutTests/platform/mac/TestExpectations:
Update expectations.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.cpp:
(PAL::WebGPU::CommandEncoderImpl::copyBufferToTexture):
(PAL::WebGPU::CommandEncoderImpl::copyTextureToBuffer):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp:
(PAL::WebGPU::QueueImpl::writeTexture):
1 is a better default than 0 since number of bytes copies is
bytesPerRow * rowsPerImage, so if rowsPerImage is not specified we
should still copy bytesPerImage.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::copyBufferToBuffer):
Early return on empty size.

(WebGPU::validateImageCopyBuffer):
This function never returned true.

(WebGPU::CommandEncoder::copyBufferToTexture):
Origins start at 0, not 1.

(WebGPU::validateCopyTextureToBuffer):
This was using the wrong enum, which has a different value.

(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToTexture):
Origins start at 0, not 1.

* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::isValidImageCopyDestination):
Assert should only be triggered in the Force32 case.

Canonical link: https://commits.webkit.org/261032@main