[webkit-changes] [WebKit/WebKit] dc7557: Build Time Regression(260367 at main): Including Type...

Kimmo Kinnunen noreply at github.com
Wed Mar 1 13:02:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc75578f021ec6b6071cce582e1fda447464f6be
      https://github.com/WebKit/WebKit/commit/dc75578f021ec6b6071cce582e1fda447464f6be
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/html/canvas/EXTDisjointTimerQuery.cpp
    M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
    M Source/WebCore/html/canvas/WebGLAny.h
    A Source/WebCore/html/canvas/WebGLAnyInlines.h
    M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

  Log Message:
  -----------
  Build Time Regression(260367 at main): Including TypedArrayInlines.h in WebGLAny.h caused increased build times
https://bugs.webkit.org/show_bug.cgi?id=252968
rdar://problem/105970124

Reviewed by Jer Noble.

Add WebGLAnyInlines.h and use it in all .cpp files that instantiate
WebGLAny. Move the TypedArrayInlines.h from WebGLAny.h to
WebGLAnyInlines.h so that only those compilation units include the
slower typed array files.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/canvas/EXTDisjointTimerQuery.cpp:
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
* Source/WebCore/html/canvas/WebGLAny.h:
* Source/WebCore/html/canvas/WebGLAnyInlines.h: Added.
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

Canonical link: https://commits.webkit.org/261020@main




More information about the webkit-changes mailing list