[webkit-changes] [WebKit/WebKit] 5e3c2e: [GLib] Ensure no final classes have public class s...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e3c2e27ef614802f06ea2408c46f823906cb35b
      https://github.com/WebKit/WebKit/commit/5e3c2e27ef614802f06ea2408c46f823906cb35b
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitDownload.h.in
    M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in

  Log Message:
  -----------
  [GLib] Ensure no final classes have public class structs
https://bugs.webkit.org/show_bug.cgi?id=252827

Reviewed by Adrian Perez de Castro.

It doesn't make sense for non-derivable classes to have virtual function
tables, and that's all we have in the class structs, so hide them away
behind the WEBKIT_DECLARE_FINAL_TYPE macro. They're technically still
present in the headers since they're generated by the macro, but they
won't contain virtual functions anymore and it's much less confusing
this way.

* Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp:
(webkit_download_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitDownload.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_class_init):
* Source/WebKit/UIProcess/API/glib/WebKitWebContext.h.in:

Canonical link: https://commits.webkit.org/261011@main