[webkit-changes] [WebKit/WebKit] d8bc46: [Cocoa] Static images should show the frame whose ...

Said Abou-Hallawa noreply at github.com
Wed Mar 1 07:51:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8bc465282794ce0568c9b4c6a932171e3a1bb1f
      https://github.com/WebKit/WebKit/commit/d8bc465282794ce0568c9b4c6a932171e3a1bb1f
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/images/image-overlay-mutiple-frames-expected.html
    A LayoutTests/fast/images/image-overlay-mutiple-frames.html
    A LayoutTests/fast/images/resources/avif_overlay-exact-bounds-last-frame.avif
    A LayoutTests/fast/images/resources/avif_overlay-exact-bounds.avif
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/platform/graphics/BitmapImage.cpp
    M Source/WebCore/platform/graphics/BitmapImage.h
    M Source/WebCore/platform/graphics/ImageDecoder.h
    M Source/WebCore/platform/graphics/ImageSource.cpp
    M Source/WebCore/platform/graphics/ImageSource.h
    M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp
    M Source/WebCore/platform/graphics/cg/ImageDecoderCG.h

  Log Message:
  -----------
  [Cocoa] Static images should show the frame whose index is primary image index
https://bugs.webkit.org/show_bug.cgi?id=245099
rdar://99479666

Reviewed by Darin Adler.

For the static image, the BitmapImage::m_currentFrame should be initialized with
CGImageSourceGetPrimaryImageIndex() after all the encoded data is received.

* LayoutTests/TestExpectations:
* LayoutTests/fast/images/image-overlay-mutiple-frames-expected.html: Added.
* LayoutTests/fast/images/image-overlay-mutiple-frames.html: Added.
* LayoutTests/fast/images/resources/avif_overlay-exact-bounds-last-frame.avif: Added.
* LayoutTests/fast/images/resources/avif_overlay-exact-bounds.avif: Added.
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::resetAnimation):
* Source/WebCore/platform/graphics/BitmapImage.h:
* Source/WebCore/platform/graphics/ImageDecoder.h:
(WebCore::ImageDecoder::primaryFrameIndex const):
* Source/WebCore/platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::clearMetadata):
(WebCore::ImageSource::primaryFrameIndex):
(WebCore::ImageSource::dump):
* Source/WebCore/platform/graphics/ImageSource.h:
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoderCG::primaryFrameIndex const):
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:

Canonical link: https://commits.webkit.org/261009@main




More information about the webkit-changes mailing list