[webkit-changes] [WebKit/WebKit] 9d5801: Cherry-pick 260601 at main (173e3ebecf4f). https://bu...

Carlos Garcia Campos noreply at github.com
Wed Mar 1 07:07:35 PST 2023


  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d5801c72f2b603f292c146304a3908f924e531b
      https://github.com/WebKit/WebKit/commit/9d5801c72f2b603f292c146304a3908f924e531b
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M Source/WTF/wtf/unix/LoggingUnix.cpp
    M Source/WebCore/platform/unix/LoggingUnix.cpp
    M Source/WebKit/Platform/unix/LoggingUnix.cpp
    M Source/WebKit/Shared/WebKit2Initialize.cpp

  Log Message:
  -----------
  Cherry-pick 260601 at main (173e3ebecf4f). https://bugs.webkit.org/show_bug.cgi?id=252558

    [GTK][WPE] UI process release log not shown
    https://bugs.webkit.org/show_bug.cgi?id=252558

    Reviewed by Michael Catanzaro.

    The problem is that logLevelString() implementation in WebKit layer
    doesn't take RELEASE_LOG_DISABLED into account. Actually the
    implementation of logLevelString() in all layers does the same, getting
    th value of WEBKIT_DEBUG env var, but with a few differences. We can
    have a single implementation in WTF and use WTF::logLevelString() from
    WebCore and WebKit.

    * Source/WTF/wtf/unix/LoggingUnix.cpp:
    (WTF::logLevelString):
    * Source/WebCore/platform/unix/LoggingUnix.cpp:
    (WebCore::logLevelString):
    * Source/WebKit/Platform/unix/LoggingUnix.cpp:
    (WebKit::logLevelString):
    * Source/WebKit/Shared/WebKit2Initialize.cpp:
    (WebKit::InitializeWebKit2): Remove log initialization here since it's already done in UIProcessLogInitialization.cpp.

    Canonical link: https://commits.webkit.org/260601@main




More information about the webkit-changes mailing list