[webkit-changes] [WebKit/WebKit] eb0336: Block access to updateQuotaBasedOnSpaceUsageForTes...

Gavin noreply at github.com
Wed Mar 1 05:23:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb0336c1fd2b77febbc99cb7b8aaf4762409eb98
      https://github.com/WebKit/WebKit/commit/eb0336c1fd2b77febbc99cb7b8aaf4762409eb98
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/wpt/cache-storage/cache-quota-after-restart.any.html
    R LayoutTests/ipc/no-test-only-ipc-expected-crash.html
    A LayoutTests/ipc/restrictedendpoints/deny-access-updateQuotaBasedOnSpaceUsageForTesting.html
    A LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash.html
    A LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed-expected.txt
    A LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed.html
    R LayoutTests/ipc/test-only-ipc-allowed-expected.txt
    R LayoutTests/ipc/test-only-ipc-allowed.html
    M Source/WebKit/CMakeLists.txt
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    A Source/WebKit/Shared/NetworkProcessConnectionParameters.h
    A Source/WebKit/Shared/NetworkProcessConnectionParameters.serialization.in
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Block access to updateQuotaBasedOnSpaceUsageForTesting when not testing
https://bugs.webkit.org/show_bug.cgi?id=253101
<rdar://106079448>

Reviewed by Alex Christensen.

Prevent IPC access to the test only updateQuotaBasedOnSpaceUsageForTesting
method when not testing.

* LayoutTests/http/wpt/cache-storage/cache-quota-after-restart.any.html:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::create):
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::m_allowTestOnlyIPC):
(WebKit::NetworkConnectionToWebProcess::updateQuotaBasedOnSpaceUsageForTesting):
(WebKit::m_schemeRegistry): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::allowTestOnlyIPC const):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/Shared/NetworkProcessConnectionParameters.h: Added.
* Source/WebKit/Shared/NetworkProcessConnectionParameters.serialization.in: Added.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/261000@main




More information about the webkit-changes mailing list