[webkit-changes] [WebKit/WebKit] cecd69: [ watchOS ] Crash in PlaybackSessionInterfaceAVKit...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cecd69451d07f0ab7eb2fbba3661ef19fa085072
      https://github.com/WebKit/WebKit/commit/cecd69451d07f0ab7eb2fbba3661ef19fa085072
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-06-30 (Fri, 30 Jun 2023)

  Changed paths:
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
    A Source/WebCore/platform/graphics/cocoa/NullVideoFullscreenInterface.h
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h

  Log Message:
  -----------
  [ watchOS ] Crash in PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit
https://bugs.webkit.org/show_bug.cgi?id=258750
rdar://110387309

Reviewed by Andy Estes and Eric Carlson.

Video playback on watchOS is disabled, but somehow pages are getting far enough along
in video playback to cause a PlaybackSessionInterfaceAVKit to be instantiated. Due to
differences in the implementation of AVKit on watchOS from iOS, our technique of creating
a WebAVPlayerController causes an unimplemented selector exception.

Since we shouldn't be playing any video on watchOS anyway, just add empty implementations
of VideoFullscreenInterface and PlaybackSessionInterface for use there.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h: Added.
* Source/WebCore/platform/graphics/cocoa/NullVideoFullscreenInterface.h: Added.
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h:

Canonical link: https://commits.webkit.org/265674@main