[webkit-changes] [WebKit/WebKit] db8fe9: REGRESSION: (264863 at main) Fix regression in CSSCal...
Chirag Shah
noreply at github.com
Fri Jun 30 13:43:46 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: db8fe90cd4538413b18338e2308c9754c37fffe3
https://github.com/WebKit/WebKit/commit/db8fe90cd4538413b18338e2308c9754c37fffe3
Author: Chirag M Shah <chirag_m_shah at apple.com>
Date: 2023-06-30 (Fri, 30 Jun 2023)
Changed paths:
A LayoutTests/fast/css/css-calc-rem-no-children-crash-expected.txt
A LayoutTests/fast/css/css-calc-rem-no-children-crash.html
M Source/WebCore/css/calc/CSSCalcValue.cpp
Log Message:
-----------
REGRESSION: (264863 at main) Fix regression in CSSCalcValue
https://bugs.webkit.org/show_bug.cgi?id=258684
rdar://111512503
Reviewed by Antti Koivisto.
This change fixes a regression introduced in rdar://109503971 where we
now create a step operation with no children. This makes sense for
CalcOperator::Round, but not for CalcOperator::Mod and CalcOperator::Rem
* LayoutTests/fast/css/css-calc-rem-no-children-crash-expected.txt: Added.
* LayoutTests/fast/css/css-calc-rem-no-children-crash.html: Added.
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::createCSS):
Canonical link: https://commits.webkit.org/265667@main
More information about the webkit-changes
mailing list