[webkit-changes] [WebKit/WebKit] b4d32d: [CSS Container Queries] Use element writing mode f...

Antti Koivisto noreply at github.com
Fri Jun 30 09:08:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4d32d728a61a0786b99f30af82b3d4c92422afd
      https://github.com/WebKit/WebKit/commit/b4d32d728a61a0786b99f30af82b3d4c92422afd
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-06-30 (Fri, 30 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt
    M Source/WebCore/css/CSSPrimitiveValue.cpp

  Log Message:
  -----------
  [CSS Container Queries] Use element writing mode for unit resolution
https://bugs.webkit.org/show_bug.cgi?id=258722
rdar://111565488

Reviewed by Simon Fraser.

Correct handling for vertical writing mode per https://github.com/w3c/csswg-drafts/issues/6873

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Resolve logical to to physical axis based on the element writing mode.
Also explicitly fall back to small viewport units to guarantee consistency.

Canonical link: https://commits.webkit.org/265654@main




More information about the webkit-changes mailing list