[webkit-changes] [WebKit/WebKit] 3f0a2a: Crash in TextManipulationController::observeParagr...

Ryosuke Niwa noreply at github.com
Wed Jun 28 23:05:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f0a2a47e444af1496dbaea11874c7a848a04e12
      https://github.com/WebKit/WebKit/commit/3f0a2a47e444af1496dbaea11874c7a848a04e12
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M Source/WebCore/editing/TextManipulationController.cpp

  Log Message:
  -----------
  Crash in TextManipulationController::observeParagraphs on macrumors.com
https://bugs.webkit.org/show_bug.cgi?id=258649

Reviewed by Wenson Hsieh.

In some cases, we can reach the end of shadow root without TextIterator hitting the end.
We need to stop the iteration in such cases to avoid dereferencing nullptr.

Unfortunately no new tests since I cannot create a reduction.

* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::ParagraphContentIterator::atEnd const):

Canonical link: https://commits.webkit.org/265612@main




More information about the webkit-changes mailing list