[webkit-changes] [WebKit/WebKit] 883a69: Revert unnecessary part of 265344 at main

Alex Christensen noreply at github.com
Wed Jun 28 13:50:28 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 883a699fc0cf1bdd0a2051ea9914f4ccfd137835
      https://github.com/WebKit/WebKit/commit/883a699fc0cf1bdd0a2051ea9914f4ccfd137835
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/ThreadSafeWeakPtr.h

  Log Message:
  -----------
  Revert unnecessary part of 265344 at main
https://bugs.webkit.org/show_bug.cgi?id=258636
rdar://111409234

Reviewed by Chris Dumez.

265344 at main made it so we can make weak references during the destructor safely.
I also tried to do the same thing we do in RefCounted and ThreadSafeRefCounted
and make it so we can safely make strong references, however m_strongReferenceCount
is also used in weakDeref so it caused the control block to be leaked if there
are weak references when the destructor is called.  As a minimum risk fix,
revert that unneeded part of last week's PR.

* Source/WTF/wtf/ThreadSafeWeakPtr.h:
(WTF::ThreadSafeWeakPtrControlBlock::strongDeref const):

Canonical link: https://commits.webkit.org/265598@main




More information about the webkit-changes mailing list