[webkit-changes] [WebKit/WebKit] 348e2c: [popover] Make togglePopover throw more exceptions

Rob Buis noreply at github.com
Wed Jun 28 10:58:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 348e2c980bf9d8cb0be366d0423fad4ce952b127
      https://github.com/WebKit/WebKit/commit/348e2c980bf9d8cb0be366d0423fad4ce952b127
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover.html
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Make togglePopover throw more exceptions
https://bugs.webkit.org/show_bug.cgi?id=258574

Reviewed by Tim Nguyen.

Throw exceptions in togglePopover in case of a disconnected node or the popover
attribute not being set anymore, see https://github.com/whatwg/html/issues/8999.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover.html:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::togglePopover):

Canonical link: https://commits.webkit.org/265589@main




More information about the webkit-changes mailing list