[webkit-changes] [WebKit/WebKit] e289c4: [GTK] API test WebKit.OnDeviceChangeCrash is flaky...

Vitaly Dyachkov noreply at github.com
Wed Jun 28 03:48:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e289c4e0a33a89bbf768362c7ff336fe132a66df
      https://github.com/WebKit/WebKit/commit/e289c4e0a33a89bbf768362c7ff336fe132a66df
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M Tools/TestWebKitAPI/glib/TestExpectations.json
    M Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
    M Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp

  Log Message:
  -----------
  [GTK] API test WebKit.OnDeviceChangeCrash is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=214805

Reviewed by Philippe Normand.

When creating a `PlatformWebView` with a related "WKPage", we need to
copy into the webview configuration not only the context and the page
group, but also the page preferenes.

* Tools/TestWebKitAPI/glib/TestExpectations.json:
* Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* Tools/TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):

Canonical link: https://commits.webkit.org/265577@main




More information about the webkit-changes mailing list