[webkit-changes] [WebKit/WebKit] fe5c47: Constructing a VideoFrame from a video element ins...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe5c478d8625ba2f640847b072d1cf2098bf625a
      https://github.com/WebKit/WebKit/commit/fe5c478d8625ba2f640847b072d1cf2098bf625a
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    A LayoutTests/http/wpt/webcodecs/videoFrame-video-element-expected.txt
    A LayoutTests/http/wpt/webcodecs/videoFrame-video-element.html
    M Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm

  Log Message:
  -----------
  Constructing a VideoFrame from a video element inside the loadeddata event does not always succeed in Safari
https://bugs.webkit.org/show_bug.cgi?id=258450
rdar://111216678

Reviewed by Eric Carlson.

When the video element is not yet playing, we receive a notification that a first frame is there.
At that point, we should be able to construct a VideoFrame from the video element.
The issue is that, when the video element starts to play, QueuedVideoOutput receives a outputSequenceWasFlushed: notification.
It then flushes its VideoFrames, which will happen later on.
Instead, if we receive outputSequenceWasFlushed: we should clear VideoFrames except if we are in paused state.
In the paused state, we should keep at least one video frame.

* LayoutTests/http/wpt/webcodecs/videoFrame-video-element-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/videoFrame-video-element.html: Added.
* Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm:
(WebCore::QueuedVideoOutput::addVideoFrameEntries):

Canonical link: https://commits.webkit.org/265574@main