[webkit-changes] [WebKit/WebKit] 234211: RTCVideoEncoderH264 should set kVTCompressionPrope...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2342117a550e6f019bc588922ed6b91a901df709
      https://github.com/WebKit/WebKit/commit/2342117a550e6f019bc588922ed6b91a901df709
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm

  Log Message:
  -----------
  RTCVideoEncoderH264 should set kVTCompressionPropertyKey_RealTime to false if latency mode is not realtime
https://bugs.webkit.org/show_bug.cgi?id=258553
rdar://111381195

Reviewed by Eric Carlson.

If latency mode is not realtime, setting kVTCompressionPropertyKey_RealTime to false makes more sense.
It will reduce the number of cases where dropped frames will happen.
This will help stabilizing tests like LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.html?h264.

We add a debug assert to check that dropped frames only happen if kVTCompressionPropertyKey_RealTime is set to true.
This might further help debugging flakinesses.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 configureCompressionSession]):
(-[RTCVideoEncoderH264 frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:rotation:isKeyFrameRequired:]):

Canonical link: https://commits.webkit.org/265560@main