[webkit-changes] [WebKit/WebKit] 70f6ce: [IFC][Invalidation] Incorrect computed damaged pos...

Alan Baradlay noreply at github.com
Tue Jun 27 06:49:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70f6ceacdaeb9f9b443d2e076915b5d8e5c817f9
      https://github.com/WebKit/WebKit/commit/70f6ceacdaeb9f9b443d2e076915b5d8e5c817f9
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    A LayoutTests/fast/inline/partial-invalidation-on-pre-line-crash-expected.txt
    A LayoutTests/fast/inline/partial-invalidation-on-pre-line-crash.html
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp

  Log Message:
  -----------
  [IFC][Invalidation] Incorrect computed damaged position when DOM and render trees are out of sync
https://bugs.webkit.org/show_bug.cgi?id=258535
<rdar://111308062>

Reviewed by Antti Koivisto.

Expand damage position adjustment to SoftLineBreak type of content.

Damage position adjustment
1. ensures the final invalidation position is before or at the damage position (meant to handle things like collapsed whitespace)
2. it is currently performed on text content only

* LayoutTests/fast/inline/partial-invalidation-on-pre-line-crash-expected.txt: Added.
* LayoutTests/fast/inline/partial-invalidation-on-pre-line-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::inlineItemPositionForDamagedContentPosition):

Canonical link: https://commits.webkit.org/265548@main




More information about the webkit-changes mailing list