[webkit-changes] [WebKit/WebKit] 47683c: [GStreamer] Report video decode errors

[Vivienne]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47683cbce224b66ec4be118dc9279b730d204e8a
      https://github.com/WebKit/WebKit/commit/47683cbce224b66ec4be118dc9279b730d204e8a
  Author: Vivienne Watermeier <vwatermeier at igalia.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/metadata/generated/element-audio.https.sub-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/metadata/generated/element-audio.sub-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/metadata/generated/element-video.https.sub-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/metadata/generated/element-video.sub-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/cross-origin-video-expected.txt
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Report video decode errors
https://bugs.webkit.org/show_bug.cgi?id=257195

Reviewed by Philippe Normand.

When a GST_STREAM_ERROR or GST_STREAM_ERROR_TYPE_NOT_FOUND occurs, the
player does not set the error to MediaPlayer::NetworkState::DecodeError,
but expects the application to do so if needed via the stalled event.
However the latter is too generic for the application to determine the
actual cause of error and decide whether this is a decode error or some
other deficiency (e.g. temporary bandwidth issues).

Original author: Michael Pantazoglou <michael.pantazoglou at oceanbluesoftware.co.uk>
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1072

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): set DecodeError

Canonical link: https://commits.webkit.org/265543@main