[webkit-changes] [WebKit/WebKit] 5b1e40: Bump process priority during responsiveness checks...

Chris Dumez noreply at github.com
Mon Jun 26 16:18:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b1e40d5fffcac79106593054a60a97e8302b0ea
      https://github.com/WebKit/WebKit/commit/5b1e40d5fffcac79106593054a60a97e8302b0ea
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

  Log Message:
  -----------
  Bump process priority during responsiveness checks to avoid false positives
https://bugs.webkit.org/show_bug.cgi?id=258536

Reviewed by Ben Nham.

We recently adopted RunningBoard on macOS and our child processes priorities
are now tied to RunningBoard assertions that we hold on their behalf. This
means that WebProcesses backing background tabs now get a much lower process
priority than they used to. Given that the responsiveness timeout is fairly
short (3 seconds), this can lead to false positives.

To address the issue, we now hold a foreground assertion during the
responsiveness check instead of the implicit background one taken by
sendWithAsyncReply().

* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::checkForResponsiveness):

Canonical link: https://commits.webkit.org/265532@main




More information about the webkit-changes mailing list